Checkstyle Results

The following document contains the results of Checkstyle .

Summary

Files

net/sf/deadbolt/DeadboltEnvironment.java

Error		Line
	File does not end with a newline.	0

net/sf/deadbolt/DeadboltEnvironment.java

Error		Line
	Line does not match expected header line of 'Copyright (C) 2005 Tim Solley.'.	1
	Line has trailing spaces.	55
	Unclosed HTML tag found: <timsolley@yahoo.com>	56
	Missing a Javadoc comment.	59
	'static' modifier out of order with the JLS suggestions.	59

net/sf/deadbolt/DeadboltFilter.java

Error		Line
	File does not end with a newline.	0

net/sf/deadbolt/DeadboltFilter.java

Error		Line
	Line does not match expected header line of 'Copyright (C) 2005 Tim Solley.'.	1
	Using the '.*' form of import should be avoided - java.util.*.	55
	Using the '.*' form of import should be avoided - javax.servlet.*.	57
	Unused import - net.sf.deadbolt.tags.DisplayErrorsTag.	64
	Line has trailing spaces.	78
	Unclosed HTML tag found: <timsolley@yahoo.com>	79
	Line is longer than 80 characters.	83
	Missing a Javadoc comment.	83
	Line is longer than 80 characters.	85
	Missing a Javadoc comment.	86
	Missing a Javadoc comment.	92
	Missing a Javadoc comment.	98
	Line has trailing spaces.	99
	Missing a Javadoc comment.	103
	Line has trailing spaces.	110
	Method 'init' is not designed for extension - needs to be abstract, final or empty.	124
	Method length is 202 lines (max allowed is 150).	124
	Parameter config should be final.	124
	Expected @param tag for 'config'.	124
	Expected @throws tag for 'ServletException'.	124
	Line is longer than 80 characters.	148
	Line has trailing spaces.	173
	Line is longer than 80 characters.	179
	'if' is not followed by whitespace.	180
	Line is longer than 80 characters.	184
	'for' is not followed by whitespace.	184
	Line is longer than 80 characters.	186
	Line is longer than 80 characters.	187
	Line is longer than 80 characters.	188
	'+' should be on a new line.	188
	Line has trailing spaces.	190
	Line is longer than 80 characters.	195
	Line is longer than 80 characters.	198
	Line is longer than 80 characters.	200
	Line is longer than 80 characters.	201
	Line has trailing spaces.	207
	Line is longer than 80 characters.	259
	Line is longer than 80 characters.	260
	Line is longer than 80 characters.	322
	Line has trailing spaces.	336
	Method 'doFilter' is not designed for extension - needs to be abstract, final or empty.	342
	Parameter request should be final.	342
	Expected @param tag for 'request'.	342
	Parameter response should be final.	342
	Expected @param tag for 'response'.	342
	Parameter chain should be final.	343
	Expected @param tag for 'chain'.	343
	Expected @throws tag for 'IOException'.	343
	Expected @throws tag for 'ServletException'.	343
	Line has trailing spaces.	352
	'if' is not followed by whitespace.	357
	'for' is not followed by whitespace.	361
	Line has trailing spaces.	373
	'if' construct must use '{}'s.	378
	Line has trailing spaces.	383
	Line has trailing spaces.	392
	'if' is not followed by whitespace.	417
	'if' is not followed by whitespace.	419
	'if' construct must use '{}'s.	445
	Line has trailing spaces.	450

net/sf/deadbolt/handlers/DeadboltHandler.java

Error		Line
	File does not end with a newline.	0

net/sf/deadbolt/handlers/DeadboltHandler.java

Error		Line
	Line does not match expected header line of 'Copyright (C) 2005 Tim Solley.'.	1
	Line has trailing spaces.	71
	Unclosed HTML tag found: <timsolley@yahoo.com>	72
	Line is longer than 80 characters.	75
	Missing a Javadoc comment.	75
	Line has trailing spaces.	83
	Line has trailing spaces.	89
	Parameter request should be final.	94
	Expected @param tag for 'request'.	94
	Parameter response should be final.	95
	Expected @param tag for 'response'.	95
	Parameter room should be final.	95
	Expected @param tag for 'room'.	95
	Line has trailing spaces.	100
	Line has trailing spaces.	104
	Line has trailing spaces.	108
	Method 'addErrorKey' is not designed for extension - needs to be abstract, final or empty.	112
	Parameter request should be final.	112
	Expected @param tag for 'request'.	112
	Parameter errorKey should be final.	112
	Expected @param tag for 'errorKey'.	112
	Line has trailing spaces.	131
	Method 'addErrors' is not designed for extension - needs to be abstract, final or empty.	136
	Parameter request should be final.	136
	Expected @param tag for 'request'.	136
	Parameter errors should be final.	136
	Line is longer than 80 characters.	139
	Line has trailing spaces.	148
	Line has trailing spaces.	152
	Line is longer than 80 characters.	156
	Method 'addErrorMessage' is not designed for extension - needs to be abstract, final or empty.	156
	Parameter request should be final.	156
	Expected @param tag for 'request'.	156
	Parameter errorMessage should be final.	156
	Expected @param tag for 'errorMessage'.	156
	Line is longer than 80 characters.	161

net/sf/deadbolt/handlers/IPFilterHandler.java

Error		Line
	Line does not match expected header line of 'Copyright (C) 2005 Tim Solley.'.	1
	Line is longer than 80 characters.	63
	Line has trailing spaces.	65
	Unclosed HTML tag found: <timsolley@yahoo.com>	66
	Line is longer than 80 characters.	69
	Missing a Javadoc comment.	69
	Line has trailing spaces.	70
	Line is longer than 80 characters.	72
	Line is longer than 80 characters.	73
	Expected an @return tag.	76
	Method 'authenticate' is not designed for extension - needs to be abstract, final or empty.	76
	Parameter request should be final.	76
	Expected @param tag for 'request'.	76
	Parameter response should be final.	77
	Expected @param tag for 'response'.	77
	Parameter room should be final.	77
	Expected @param tag for 'room'.	77
	Line has trailing spaces.	79
	Line has trailing spaces.	83
	Line has trailing spaces.	87
	Line is longer than 80 characters.	90
	'if' is not followed by whitespace.	90
	Line is longer than 80 characters.	91
	Line has trailing spaces.	93
	'if' is not followed by whitespace.	95
	'for' is not followed by whitespace.	100
	Line has trailing spaces.	104
	Line is longer than 80 characters.	105
	'if' is not followed by whitespace.	105
	Line is longer than 80 characters.	106
	Line is longer than 80 characters.	110
	Line has trailing spaces.	114
	'if' is not followed by whitespace.	116
	'for' is not followed by whitespace.	121
	Line has trailing spaces.	125
	Line is longer than 80 characters.	126
	'if' is not followed by whitespace.	126
	Line is longer than 80 characters.	127
	Line is longer than 80 characters.	130
	Line has trailing spaces.	135

net/sf/deadbolt/handlers/SQLInjectionHandler.java

Error		Line
	Line does not match expected header line of 'Copyright (C) 2005 Tim Solley.'.	1
	Using the '.*' form of import should be avoided - java.util.*.	54
	Line has trailing spaces.	65
	Unclosed HTML tag found: <timsolley@yahoo.com>	66
	Line is longer than 80 characters.	69
	Missing a Javadoc comment.	69
	Line has trailing spaces.	70
	First sentence should end with a period.	71
	Line has trailing spaces.	75
	Line is longer than 80 characters.	76
	Missing a Javadoc comment.	76
	Line is longer than 80 characters.	77
	Line is longer than 80 characters.	78
	Missing a Javadoc comment.	80
	Line has trailing spaces.	81
	Missing a Javadoc comment.	82
	Line has trailing spaces.	83
	Line has trailing spaces.	86
	Expected an @return tag.	88
	Line has trailing spaces.	88
	Method 'authenticate' is not designed for extension - needs to be abstract, final or empty.	88
	Parameter request should be final.	88
	Expected @param tag for 'request'.	88
	Parameter response should be final.	89
	Expected @param tag for 'response'.	89
	Parameter room should be final.	89
	Expected @param tag for 'room'.	89
	Line has trailing spaces.	91
	Line has trailing spaces.	93
	Line has trailing spaces.	94
	'if' is not followed by whitespace.	100
	Line has trailing spaces.	105
	Line is longer than 80 characters.	108
	'if' is not followed by whitespace.	109
	'for' is not followed by whitespace.	111
	'}' should be on the same line.	115
	'else' construct must use '{}'s.	116
	'for' is not followed by whitespace.	119
	'if' is not followed by whitespace.	122
	Line is longer than 80 characters.	123
	Line is longer than 80 characters.	124
	Line has trailing spaces.	126
	'if' is not followed by whitespace.	127
	Line has trailing spaces.	131
	Line has trailing spaces.	135
	Line has trailing spaces.	137
	Line has trailing spaces.	139
	Expected an @return tag.	145
	Line is longer than 80 characters.	145
	Parameter value should be final.	145
	Expected @param tag for 'value'.	145
	Parameter request should be final.	145
	Expected @param tag for 'request'.	145
	Parameter room should be final.	145
	Expected @param tag for 'room'.	145
	Line has trailing spaces.	149
	'for' is not followed by whitespace.	150
	Line is longer than 80 characters.	151
	'if' is not followed by whitespace.	152
	Line is longer than 80 characters.	154
	Line has trailing spaces.	164

net/sf/deadbolt/handlers/package.html

Error		Line
	Missing package documentation file.	0

net/sf/deadbolt/model/Room.java

Error		Line
	File does not end with a newline.	0

net/sf/deadbolt/model/Room.java

Error		Line
	Line does not match expected header line of 'Copyright (C) 2005 Tim Solley.'.	1
	Line has trailing spaces.	60
	Unclosed HTML tag found: <timsolley@yahoo.com>	61
	Missing a Javadoc comment.	64
	Missing a Javadoc comment.	66
	Missing a Javadoc comment.	68
	Method 'getInitParams' is not designed for extension - needs to be abstract, final or empty.	73
	Method 'setInitParams' is not designed for extension - needs to be abstract, final or empty.	81
	Parameter initParams should be final.	81
	'initParams' hides a field.	81
	Method 'getErrorPage' is not designed for extension - needs to be abstract, final or empty.	88
	Method 'setErrorPage' is not designed for extension - needs to be abstract, final or empty.	96
	Parameter errorPage should be final.	96
	'errorPage' hides a field.	96
	Method 'getHandlers' is not designed for extension - needs to be abstract, final or empty.	103
	Unused @param tag for 'handler'.	108
	Method 'setHandler' is not designed for extension - needs to be abstract, final or empty.	111
	Parameter handlers should be final.	111
	'handlers' hides a field.	111
	Expected @param tag for 'handlers'.	111
	Line has trailing spaces.	114
	Line has trailing spaces.	116
	Expected an @return tag.	120
	Method 'getInitParam' is not designed for extension - needs to be abstract, final or empty.	120
	Parameter key should be final.	120
	Expected @param tag for 'key'.	120
	Line has trailing spaces.	123
	Expected an @return tag.	130
	Method 'initParamExists' is not designed for extension - needs to be abstract, final or empty.	130
	Parameter key should be final.	130
	Expected @param tag for 'key'.	130
	Conditional logic can be removed.	131
	'if' is not followed by whitespace.	131

net/sf/deadbolt/model/URLMapping.java

Error		Line
	File does not end with a newline.	0

net/sf/deadbolt/model/URLMapping.java

Error		Line
	Line does not match expected header line of 'Copyright (C) 2005 Tim Solley.'.	1
	Line has trailing spaces.	57
	Unclosed HTML tag found: <timsolley@yahoo.com>	58
	Missing a Javadoc comment.	61
	Missing a Javadoc comment.	63
	Method 'getRoom' is not designed for extension - needs to be abstract, final or empty.	68
	Method 'setRoom' is not designed for extension - needs to be abstract, final or empty.	76
	Parameter room should be final.	76
	'room' hides a field.	76
	Method 'getUrlPattern' is not designed for extension - needs to be abstract, final or empty.	83
	Method 'setUrlPattern' is not designed for extension - needs to be abstract, final or empty.	91
	Parameter urlPattern should be final.	91
	'urlPattern' hides a field.	91

net/sf/deadbolt/model/package.html

Error		Line
	Missing package documentation file.	0

net/sf/deadbolt/package.html

Error		Line
	Missing package documentation file.	0

net/sf/deadbolt/tags/DisplayErrorsTag.java

Error		Line
	File does not end with a newline.	0

net/sf/deadbolt/tags/DisplayErrorsTag.java

Error		Line
	Line does not match expected header line of 'Copyright (C) 2005 Tim Solley.'.	1
	Line has trailing spaces.	68
	Unclosed HTML tag found: <timsolley@yahoo.com>	69
	Line is longer than 80 characters.	72
	Missing a Javadoc comment.	72
	Missing a Javadoc comment.	74
	Expected an @return tag.	81
	Method 'doEndTag' is not designed for extension - needs to be abstract, final or empty.	81

net/sf/deadbolt/tags/package.html

Error		Line
	Missing package documentation file.	0